Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(services): setup services before peerinfo is updated #1120

Merged
merged 3 commits into from
Jun 7, 2024

Conversation

diegomrsantos
Copy link
Collaborator

@diegomrsantos diegomrsantos commented Jun 6, 2024

  • Setup services before peerinfo is updated - this allows services to set address mappers.
  • Fix HP interop tests - improve condition related to relay addr being published.
  • Disable wildcard resolver in testautonatservice and test testautorelay.

@diegomrsantos diegomrsantos force-pushed the services-setup branch 3 times, most recently from 1f78c01 to 2500319 Compare June 6, 2024 23:03
@diegomrsantos diegomrsantos changed the title fix(services): setup services before update peerinfo fix(services): setup services before peerinfo is updated Jun 6, 2024
@diegomrsantos diegomrsantos marked this pull request as ready for review June 6, 2024 23:14
@diegomrsantos diegomrsantos enabled auto-merge (squash) June 6, 2024 23:15
@kaiserd
Copy link
Collaborator

kaiserd commented Jun 7, 2024

Thank you.
Why do disable testautonatservice and test testautorelay fail with the wildcard resolver being active?

@diegomrsantos
Copy link
Collaborator Author

Thank you. Why do disable testautonatservice and test testautorelay fail with the wildcard resolver being active?

Cause now peerInfo.addrs is populated with the resolved addresses right after the switch is started and the tests are probably not expecting that.

@kaiserd
Copy link
Collaborator

kaiserd commented Jun 7, 2024

Let's add an issue capturing the task of adjusting these tests so that we can add them back in.
For now, this PR is OK.

@diegomrsantos diegomrsantos merged commit 120549e into master Jun 7, 2024
9 checks passed
@diegomrsantos diegomrsantos deleted the services-setup branch June 7, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: done
Development

Successfully merging this pull request may close these issues.

2 participants