Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(service): add wildcard address resolver #1099
feat(service): add wildcard address resolver #1099
Changes from 35 commits
9914618
7990325
04f8b83
d04d3a0
368ab10
d2a4e84
399041a
90b9734
36ae955
19b8273
0a2df2b
4196b4a
51339c2
99dbeaf
d834b3e
2216dac
c9e877e
0e472ef
5719454
7bbc071
0b78975
c11586c
edf91dd
54dbf1f
8c19cac
1bb1c1a
e0a380e
2a1e1f0
7b803ad
385a595
433a2ba
65c3e88
2235b4b
ea34224
c4bcd53
90bc65f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI: We should change this to IFT. I'll sync with legal and come back.
We can change this in a follow up PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we change all nim-libp2p files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ill get back once legal gets back to me.
I asked that question :).
In any case, we can do that in a follow up PR.