fix: Asynchronous task [sendMsgSlow()] was cancelled [FutureDefect] #1094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnetheduck
approved these changes
May 7, 2024
cheatfate
reviewed
May 8, 2024
| @@ -304,7 +304,7 @@ proc sendMsgSlow(p: PubSubPeer, msg: seq[byte]) {.async.} = | |||
| if p.sendConn == nil: | |||
| # Wait for a send conn to be setup. `connectOnce` will | |||
| # complete this even if the sendConn setup failed | |||
| await p.connectedFut | |||
| discard await race(p.connectedFut) | |||
There was a problem hiding this comment.
why not join(p.connectedFut)?
There was a problem hiding this comment.
it's not in the chronos release libp2p uses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for:
crash on Nimbus 24.4.0 in production 9:03 EDT. 09:03:24.578950-04:00 localhost nimbus-beacon[4803]: Error: unhandled exception: Asynchronous task [sendMsgSlow() at pubsubpeer.nim:301] was cancelled! [FutureDefect]Using
awaiton a sharedFuturecan raise an unexpectedCancelledErrorif thisFuturegets canceled indirectly by another task.race(andjoinin newer versions of chronos) creates a separate future that "insulates" the shared future from the cancellation flow. See status-im/nim-chronos@8166d7d#diff-a6bc56e6ac55acab484b1a94671287d6f72bc6311b3ea43482b438b517ec9390R172.