Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanups #1092

Merged
merged 6 commits into from
May 8, 2024
Merged

cleanups #1092

merged 6 commits into from
May 8, 2024

Conversation

arnetheduck
Copy link
Contributor

  • remove redundant error handling (reduces warnings)
  • remove reundant copying

* remove redundant error handling (reduces warnings)
* remove reundant copying
* add some docs
* add missing penalty for invalid messages
* simplify code
* remove unused gossipsub fields
@kaiserd kaiserd self-requested a review May 8, 2024 09:45
Copy link
Collaborator

@kaiserd kaiserd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much. LGTM.

This reverts commit 14499ad.
It will be added in a separate PR.
@kaiserd
Copy link
Collaborator

kaiserd commented May 8, 2024

moving the gossipsub cleanups in a separate PR.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 92.59259% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 84.51%. Comparing base (02c96fc) to head (354513b).
Report is 3 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1092      +/-   ##
==========================================
- Coverage   84.53%   84.51%   -0.03%     
==========================================
  Files          91       91              
  Lines       15517    15529      +12     
==========================================
+ Hits        13118    13125       +7     
- Misses       2399     2404       +5     
Files Coverage Δ
libp2p/multiaddress.nim 86.93% <ø> (ø)
libp2p/protocols/pubsub/gossipsub/behavior.nim 89.02% <100.00%> (+0.19%) ⬆️
libp2p/protocols/pubsub/gossipsub/scoring.nim 90.06% <ø> (-0.13%) ⬇️
libp2p/protocols/pubsub/pubsub.nim 84.29% <ø> (ø)
libp2p/protocols/pubsub/rpc/messages.nim 52.85% <ø> (ø)
libp2p/transports/tcptransport.nim 80.57% <100.00%> (ø)
libp2p/multistream.nim 86.17% <50.00%> (+0.07%) ⬆️
libp2p/protocols/pubsub/mcache.nim 82.75% <91.66%> (-9.25%) ⬇️

... and 3 files with indirect coverage changes

@kaiserd kaiserd merged commit 21cbe3a into master May 8, 2024
9 checks passed
@kaiserd kaiserd deleted the cleanups branch May 8, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: done
Development

Successfully merging this pull request may close these issues.

3 participants