-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanups #1092
Conversation
arnetheduck
commented
May 6, 2024
- remove redundant error handling (reduces warnings)
- remove reundant copying
* add some docs * add missing penalty for invalid messages * simplify code * remove unused gossipsub fields
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much. LGTM.
This reverts commit 14499ad. It will be added in a separate PR.
moving the gossipsub cleanups in a separate PR. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1092 +/- ##
==========================================
- Coverage 84.53% 84.51% -0.03%
==========================================
Files 91 91
Lines 15517 15529 +12
==========================================
+ Hits 13118 13125 +7
- Misses 2399 2404 +5
|