Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: yamux metrics #1022

Merged
merged 2 commits into from
Feb 8, 2024
Merged

fix: yamux metrics #1022

merged 2 commits into from
Feb 8, 2024

Conversation

lchenut
Copy link
Collaborator

@lchenut lchenut commented Feb 5, 2024

Simulating yamux with a few hundred nodes showed some compilation issues with the way the metrics were implemented.

  • Buckets are now ordered (which was causing a compilation error).
  • write now updates libp2p_yamux_send_queue and not libp2p_yamux_recv_queue

Copy link

codecov bot commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (eb0890c) 83.18% compared to head (9391568) 83.18%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           unstable    #1022   +/-   ##
=========================================
  Coverage     83.18%   83.18%           
=========================================
  Files            91       91           
  Lines         15349    15349           
=========================================
  Hits          12768    12768           
  Misses         2581     2581           
Files Coverage Δ
libp2p/muxers/yamux/yamux.nim 90.67% <ø> (ø)

@lchenut lchenut merged commit c1dfd58 into unstable Feb 8, 2024
11 checks passed
@lchenut lchenut deleted the fix-metrics-yamux branch February 8, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: done
Development

Successfully merging this pull request may close these issues.

2 participants