Skip to content

Add documentation for schemas in TypeScript #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 10, 2021

Conversation

simonplend
Copy link
Collaborator

@simonplend simonplend commented Aug 3, 2021

When defining JSON schemas in TypeScript, you will receive a compilation error unless you cast the schema object with as const.

Fixes #39.

When defining JSON schemas in TypeScript, you will receive a
compilation error unless you cast the schema object with `as const`.

Related issue: #39
@simonplend simonplend self-assigned this Aug 3, 2021
@simonplend simonplend added this to the Release v2.2.0 milestone Aug 3, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2021

Codecov Report

Merging #89 (c85e1c3) into main (7858cda) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #89   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           26        26           
=========================================
  Hits            26        26           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7858cda...c85e1c3. Read the comment docs.

@simonplend simonplend mentioned this pull request Aug 3, 2021
@simonplend simonplend merged commit 9c5112c into main Aug 10, 2021
@simonplend simonplend deleted the documentation-typescript-schemas branch August 10, 2021 11:52
@Beraliv
Copy link

Beraliv commented Aug 12, 2021

Sorry for the late check, looks good @simonplend !

@simonplend
Copy link
Collaborator Author

@Beraliv No problem at all. Thank you for reviewing it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2.1.0 breaks TS build
3 participants