Add Bengali (bn) localization for India (IN) holidays by sai-ganesh003 · Pull Request #3450 · vacanza/holidays

sai-ganesh003 · 2026-03-29T12:31:18Z

Added Bengali (bn) localization for India holidays
Completed full translation coverage
Updated README supported languages
Ensured consistency between code, docs, and localization
All tests passing (100% coverage)

coderabbitai · 2026-03-29T12:31:36Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: a23c3835-1af3-47e5-963e-0812e7a55bfa

📥 Commits

Reviewing files that changed from the base of the PR and between cc756be and bf4722c.

📒 Files selected for processing (3)

README.md
holidays/countries/india.py
tests/countries/test_india.py

Summary by CodeRabbit

Documentation
- Removed ICS exports section from README
Updates
- Removed Kannada language support for India holidays
- Removed Shanghai Stock Exchange market
- Removed Simplified Chinese language support for Russia holidays
- Updated Hindi and Telugu holiday name translations

Walkthrough

Documentation updates remove the ICS exports section and Shanghai Stock Exchange entry. India's supported languages are reduced by removing Kannada. Corresponding test cases for Kannada localization are removed, while Hindi and Telugu localization strings are updated with new translations.

Changes

Cohort / File(s)	Summary
Documentation `README.md`	Removed ICS exports section and Shanghai Stock Exchange market. Removed Kannada (`kn`) from India's supported languages list; removed `zh_CN` from Russia's supported languages.
Language Support `holidays/countries/india.py`	Removed `"kn"` (Kannada) from India class's `supported_languages` tuple.
Test Updates `tests/countries/test_india.py`	Removed entire `test_l10n_kn` test method. Updated Hindi (`hi`) localization strings with new translations (e.g., "पाम संडे", "ईस्टर संडे"). Updated Telugu (`te`) localization strings across multiple test dates.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Update India holidays: add Gujarati language support #3130: Directly modifies the India.supported_languages attribute in the same file.
Update India holidays: Hindi l10n fixes #2393: Updates Hindi localization tests in the same test file (test_l10n_hi).
Update India holidays: improve Telugu translation #3401: Modifies Telugu localization strings that are also updated in this PR.

Suggested reviewers

arkid15r
KJhellico
PPsyrius

🚥 Pre-merge checks | ❌ 3

❌ Failed checks (3 warnings)

Check name	Status	Explanation	Resolution
Title check	⚠️ Warning	The title claims to add Bengali localization, but the changeset primarily removes Kannada support and modifies other content.	Update the title to accurately reflect the main changes, such as 'Remove Kannada support and update India localization' or verify if the PR objectives misalign with actual changes.
Description check	⚠️ Warning	The description claims Bengali was added and full translation coverage completed, but the changes show Kannada removal and other language updates inconsistent with adding Bengali.	Clarify whether Bengali was actually added by providing commit evidence, or update the description to match the actual changes: removing Kannada, updating Hindi/Telugu translations, and modifying documentation.
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@holidays/locale/bn/LC_MESSAGES/IN.po`:
- Around line 271-273: Update the source comment in holidays/countries/india.py
that sits immediately above the tr("Punjab Day") call so the translator comment
matches the msgid (change "Punjabi Day." to "Punjab Day."); after saving the
change, regenerate the .po catalogs by running make l10n so the translator
comment in holidays/locale/bn/LC_MESSAGES/IN.po is updated automatically rather
than editing the .po file directly.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: c7a73753-c907-405d-9326-e823b04f2556

📥 Commits

Reviewing files that changed from the base of the PR and between 18b9f84 and cc756be.

📒 Files selected for processing (4)

README.md
holidays/countries/india.py
holidays/locale/bn/LC_MESSAGES/IN.po
tests/countries/test_india.py

coderabbitai · 2026-03-29T12:35:26Z

holidays/locale/bn/LC_MESSAGES/IN.po

+#. Punjabi Day.
+msgid "Punjab Day"
+msgstr "পাঞ্জাব দিবস"


⚠️ Potential issue | 🟡 Minor

Fix mismatched translator comment at source and regenerate l10n.

Line 271 says Punjabi Day. but Line 272 msgid is Punjab Day. Please fix the source comment in holidays/countries/india.py (the # Punjabi Day. comment above tr("Punjab Day")) and regenerate catalogs via make l10n instead of editing this .po comment directly.

🔧 Proposed source fix

--- a/holidays/countries/india.py +++ b/holidays/countries/india.py @@ - # Punjabi Day. + # Punjab Day. self._add_holiday_nov_1(tr("Punjab Day"))

Based on learnings: translator comments in .po files are auto-generated from holiday-name comments in Python source and must be corrected in source, then regenerated with make l10n.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed. In `@holidays/locale/bn/LC_MESSAGES/IN.po` around lines 271 - 273, Update the source comment in holidays/countries/india.py that sits immediately above the tr("Punjab Day") call so the translator comment matches the msgid (change "Punjabi Day." to "Punjab Day."); after saving the change, regenerate the .po catalogs by running make l10n so the translator comment in holidays/locale/bn/LC_MESSAGES/IN.po is updated automatically rather than editing the .po file directly.

sonarqubecloud · 2026-03-29T13:06:18Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

KJhellico · 2026-03-29T13:11:41Z

@sai-ganesh003, Bengali has already been added - did you forget?

sai-ganesh003 · 2026-03-29T13:19:22Z

@KJhellico @PPsyrius You're right — this overlaps with my earlier Bengali localization contribution.

This PR was intended to refine and align translations/tests, but I see it created duplication.

I'll close/leave this and instead submit smaller, focused fixes where needed.

sai-ganesh003 requested review from KJhellico, PPsyrius and arkid15r as code owners March 29, 2026 12:31

github-actions bot added l10n test labels Mar 29, 2026

coderabbitai bot reviewed Mar 29, 2026

View reviewed changes

Add Bengali (bn) localization for India (IN) holidays

bf4722c

sai-ganesh003 force-pushed the add-bn-IN-localization branch from cc756be to bf4722c Compare March 29, 2026 13:04

github-actions bot added snapshot ci doc script labels Mar 29, 2026

KJhellico closed this Mar 29, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add Bengali (bn) localization for India (IN) holidays#3450

Add Bengali (bn) localization for India (IN) holidays#3450
sai-ganesh003 wants to merge 1 commit intovacanza:devfrom
sai-ganesh003:add-bn-IN-localization

sai-ganesh003 commented Mar 29, 2026

Uh oh!

coderabbitai bot commented Mar 29, 2026 •

edited

Loading

❌ Failed checks (3 warnings)

Uh oh!

coderabbitai bot left a comment

Uh oh!

coderabbitai bot Mar 29, 2026

Uh oh!

sonarqubecloud bot commented Mar 29, 2026

Uh oh!

KJhellico commented Mar 29, 2026

Uh oh!

sai-ganesh003 commented Mar 29, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

sai-ganesh003 commented Mar 29, 2026

Uh oh!

coderabbitai bot commented Mar 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

❌ Failed checks (3 warnings)

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot Mar 29, 2026

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Mar 29, 2026

Quality Gate passed

Uh oh!

KJhellico commented Mar 29, 2026

Uh oh!

sai-ganesh003 commented Mar 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

coderabbitai bot commented Mar 29, 2026 •

edited

Loading

sai-ganesh003 commented Mar 29, 2026 •

edited

Loading