Skip to content

refactor: extract dialog size properties into separate mixin #9735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 14, 2025
Merged

refactor: extract dialog size properties into separate mixin #9735

merged 2 commits into from
Jul 14, 2025

Conversation

web-padawan
Copy link
Member

Description

Created DialogSizeMixin to be reused by vaadin-confirm-dialog instead of DialogBaseMixin.

Type of change

  • Refactor

@web-padawan web-padawan mentioned this pull request Jul 14, 2025
Merged
DiegoCardoso
DiegoCardoso reviewed Jul 14, 2025
View reviewed changes
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@web-padawan web-padawan removed the request for review from sissbruecker July 14, 2025 15:09
@web-padawan web-padawan merged commit 0c53ae1 into main Jul 14, 2025
10 checks passed
@web-padawan web-padawan deleted the refactor/dialog-size-mixin branch July 14, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DiegoCardoso DiegoCardoso DiegoCardoso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@web-padawan @DiegoCardoso