-
Notifications
You must be signed in to change notification settings - Fork 86
refactor: open date picker overlay on element focus in fullscreen #9670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This change overrides the `focus` method to change how focus is handled when the element is in fullscreen mode and it's focused. This is needed to avoid the element being immediatelly removed by the Grid Pro when the user is in a device with small viewport. The element receives focus, but the `_onFocus` listener has a similar detection which removes the focus from the input element, which causes the component to be removed from the cell when used as a custom editor. Part of #9158
I was able to refactor the As this PR prevents the input element from being focused, calling WDYT, @web-padawan? |
IMO it makes sense to remove that test in this case. The behavior change sounds good to me. |
|
) (#9716) Co-authored-by: Diego Cardoso <diego@vaadin.com>
) (#9717) Co-authored-by: Diego Cardoso <diego@vaadin.com>
Description
This change overrides the
focus
method to change how focus is handled when the element is in fullscreen mode and it's focused. This is needed to avoid the element being immediately removed by the Grid Pro when the user is on a device with small viewport. The element receives focus, but the_onFocus
listener has a similar detection, which removes the focus from the input element, which causes the component to be removed from the cell when used as a custom editor.Part of #9158
Type of change
Refactor