refactor: MDL layout and view transitions styles #9665
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
web-padawan
approved these changes
Jul 9, 2025
web-padawan
added a commit
that referenced
this pull request
Jul 9, 2025
* refactor: MDL layout and view transitions styles * test: update screenshots * Update master-detail-layout.html * fix: vertical drawer size * test: check position on the correct element * test: adjust tests for masterMinSize and detailMinSize * test: update test to use detailSize * test: update snapshot * chore: fix prettier warning in dev page * test: remove test that is no longer valid with new logic * test: check display on the wrapper element * fix: move detail backdrop click listener to detail wrapper * fix: align Lumo CSS with JS version * chore: fix dev page formatting for icon * chore: remove JSDoc for custom CSS properties * chore: add prettier-ignore * fix: split mode transition for RTL --------- Co-authored-by: web-padawan <iamkulykov@gmail.com>
web-padawan
added a commit
that referenced
this pull request
Jul 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a wrapper element around [part=detail] to allow view transitions on different sized drawer elements in and out at the same time.
The only reason the wrapper is exposed as
part="_detail-internal"is so that we can target it with view transitions. It’s considered as private API.Reimplement view transition styles to take advantage of the new wrapper element, and reuse the same animations for all the modes and transition types (add/remove/replace) as much as possible.