refactor: remove usage of CSS layers from base styles #9659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
commented
Jul 8, 2025
| @@ -3,62 +3,60 @@ | |||
| * Copyright (c) 2020 - 2025 Vaadin Ltd. | |||
| * This program is available under Apache License Version 2.0, available at https://vaadin.com/license/ | |||
| */ | |||
| import '@vaadin/component-base/src/style-props.js'; | |||
There was a problem hiding this comment.
Added missing import since the component uses --vaadin-focus-ring-width defined in style-props.js.
web-padawan
commented
Jul 8, 2025
| @@ -3,270 +3,269 @@ | |||
| * Copyright (c) 2024 - 2025 Vaadin Ltd. | |||
| * This program is available under Apache License Version 2.0, available at https://vaadin.com/license/ | |||
| */ | |||
| import '@vaadin/component-base/src/style-props.js'; | |||
There was a problem hiding this comment.
Added missing import.
web-padawan
commented
Jul 8, 2025
| html { | ||
| /* Background color */ | ||
| --vaadin-background-color: light-dark(#fff, #222); | ||
| :where(html) { |
There was a problem hiding this comment.
Changed to align with the approach used in Lumo.
web-padawan
commented
Jul 8, 2025
| @@ -3,57 +3,56 @@ | |||
| * Copyright (c) 2021 - 2025 Vaadin Ltd. | |||
| * This program is available under Apache License Version 2.0, available at https://vaadin.com/license/ | |||
| */ | |||
| import '@vaadin/component-base/src/style-props.js'; | |||
There was a problem hiding this comment.
Added missing import as the component uses --vaadin-clickable-cursor defined in style-props.js.
web-padawan
commented
Jul 8, 2025
| @@ -3,30 +3,29 @@ | |||
| * Copyright (c) 2021 - 2025 Vaadin Ltd. | |||
| * This program is available under Apache License Version 2.0, available at https://vaadin.com/license/ | |||
| */ | |||
| import '@vaadin/component-base/src/style-props.js'; | |||
There was a problem hiding this comment.
Added missing import.
|
web-padawan
commented
Jul 8, 2025
| vaadin-side-nav-item:has(> vaadin-icon[slot='prefix'])::part(link) { | ||
| --_has-prefix-icon:; | ||
| } | ||
| :where(vaadin-side-nav-item:has(> vaadin-icon[slot='prefix']))::part(link) { |
There was a problem hiding this comment.
Not sure if we need :where here but I added it to align with other components using SlotStylesMixin.
vursen
approved these changes
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As previously agreed, let's remove
@layerfrom base styles to make it easier for themes to override certain properties without having specificity issues. This also removes corresponding Stylelint rule.Note: please review with "hide whitespaces" option enabled.
Type of change