experiment: add map base-styles and visual tests #9650
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
force-pushed
the
experiment/base-map
branch
from
4963392 to
194f633
Compare
web-padawan
force-pushed
the
experiment/base-map
branch
from
194f633 to
ca3f6bf
Compare
jouni
approved these changes
Jul 8, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added
vaadin-mapbase styles and visual tests.New custom properties:
--vaadin-map-border-color--vaadin-map-border-radius--vaadin-map-control-shadow--vaadin-map-control-size--vaadin-map-control-background--vaadin-map-control-color--vaadin-map-control-color-hover--vaadin-map-attribution-colorTheme variant:
no-border- Lumo usesborderless, maybe we can make a breaking change to rename it?Type of change
Note
We need to add "fullscreen" and "arrow" SVG icons, then I could update corresponding controls to use
mask-image.Otherwise it feels quite inconsistent. Lumo version could also benefit from a new "fullscreen" font icon to look better.
I'll create a follow-up PR to see what it takes to make Lumo extend these base styles (and remove base layer reset).