experiment: add context-menu base styles and visual tests #9642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Styles LGTM. @web-padawan, can you coordinate/handle the visual tests? |
|
Merged the CSS layer removal PR, I'll rebase this one and add visual tests. |
web-padawan
force-pushed
the
base-context-menu
branch
from
4313785 to
ee5eea5
Compare
web-padawan
changed the title
|
web-padawan
approved these changes
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New ContextMenu base style
Supported custom properties
No new properties added.
Concerns
The
menu-item-checkedselector appears in bothcontext-menu-item-base-stylesandmenu-bar-item-base-styles. Consider moving it toitem-base-stylesto avoid duplication?