experiment: add notification base styles #9540
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jouni
commented
Jun 25, 2025
Comment on lines
+146
to
+149
| /* TODO (SAFARI-WORKAROUND-PART-2): without this, rendering isn't updated properly for the card that changes from order 1 -> 2 (max-height doesn't update) */ | ||
| /* Either this needs to be implemented with SlotStylesMixin or we need to find a way to trigger the same behavior with shadow DOM styles */ | ||
| vaadin-notification-card[style] { | ||
| } |
There was a problem hiding this comment.
If we can't find a better solution, then this needs to be implemented as slotted styles.
Update multiple.test.js
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #9525 (Update: I’m not sure that is absolutely needed, as we might be able to use `:nth-child(1 of [slot="..."]) instead.)
Screen.Recording.2025-06-25.at.9.43.00.mov
Supported custom properties
--vaadin-notification-viewport-inset--vaadin-notification-width--vaadin-notification-background--vaadin-notification-padding--vaadin-notification-gap--vaadin-notification-border-width--vaadin-notification-border-color--vaadin-notification-border-radius--vaadin-notification-box-shadowRemaining issues:
tabindex=0), or some other trick, for the hover styles to work, so that you can expand a stack of notifications.