Skip to content

feat: port side-nav Lumo styles to CSS files #9515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2025

Conversation

vursen
Copy link
Contributor

@vursen vursen commented Jun 19, 2025

Description

Depends on

Part of #9082

Type of change

  • Feature

@vursen vursen force-pushed the port-lumo-styles-to-css-files_side-nav branch from 0bce399 to 66d5637 Compare June 19, 2025 12:50
@vursen vursen force-pushed the port-lumo-styles-to-css-files_side-nav branch from 66d5637 to 30fce4a Compare June 19, 2025 13:11
@vursen vursen requested a review from jouni June 19, 2025 13:11
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

transform: none;
}

@supports selector(:focus-visible) {
Copy link
Member

@web-padawan web-padawan Jun 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to wrap this with @supports now when all supported browsers support :focus-visible.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed. I'll address it in a separate PR.

@vursen vursen requested a review from DiegoCardoso June 23, 2025 10:10
@vursen vursen merged commit e815c04 into main Jun 24, 2025
9 of 10 checks passed
@vursen vursen deleted the port-lumo-styles-to-css-files_side-nav branch June 24, 2025 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants