refactor!: replace SVG with <div> and custom font with Lumo icon #9316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
reviewed
May 27, 2025
vursen
force-pushed
the
avatar_replace_svg_with_div_use_lumo_icon
branch
from
8a3f861 to
d0e894f
Compare
vursen
commented
May 27, 2025
There was a problem hiding this comment.
The change likely stems from a rendering difference between SVG and HTML. The new version, however, seems slightly better aligned to my eye.
jouni
approved these changes
May 27, 2025
| @@ -40,23 +40,15 @@ export const avatarStyles = css` | |||
| } | |||
|
|
|||
| [part='icon'] { | |||
| font-size: 5.6em; | |||
| height: 100%; | |||
| mask: var(--_vaadin-icon-user) no-repeat center / 74%; | |||
There was a problem hiding this comment.
Today I learned about this shorthand syntax, nice 😃
web-padawan
approved these changes
May 28, 2025
vursen
changed the title
|
This was referenced May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
<svg part="icon">with<div part="icon">vaadin-avatar-iconsfont--lumo-icons-userinstead of the custom font iconFixes #9309
Type of change