fix: make first item focusable when selected is negative #7574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
vursen
approved these changes
Jul 19, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
Jul 19, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
Jul 19, 2024
web-padawan
added a commit
that referenced
this pull request
Jul 19, 2024
web-padawan
added a commit
that referenced
this pull request
Jul 19, 2024
FrediWa
pushed a commit
that referenced
this pull request
Jul 24, 2024
|
This ticket/PR has been released with Vaadin 24.5.0.alpha6 and is also targeting the upcoming stable 24.5.0 version. |
This was referenced Aug 29, 2024
Closed
Closed
Merged
Merged
Closed
Closed
Closed
This was referenced Aug 31, 2024
Open
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #6392
The issue is caused by
_getAvailableIndexhelper. Due to roving tabindex, it switches to the last item if theidxis less than 0. But in this particular case, it becomes a problem as the last item getstabindex="0"(instead of the first one).As we already have a call to
_setFocusable()where we check ifselectedis non-empty, I figured out the easiest fix is to update it to pass0also for cases whenselectedis less than 0. This way the first available item getstabindex="0".Type of change