fix: render at most 7 weekdays in datepicker #7542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sissbruecker
approved these changes
Jul 12, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
Jul 12, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
Jul 12, 2024
sissbruecker
pushed a commit
that referenced
this pull request
Jul 12, 2024
web-padawan
pushed a commit
that referenced
this pull request
Jul 12, 2024
Collaborator
|
This ticket/PR has been released with Vaadin 24.5.0.alpha5 and is also targeting the upcoming stable 24.5.0 version. |
This was referenced Aug 29, 2024
Closed
Closed
Merged
Merged
Closed
Closed
Closed
This was referenced Aug 31, 2024
Open
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Nothing stops the user from setting more than 7 weekdays, this PR renders only the first 7 of the given weekdays.
Weekday items are given a width of 100%/7 meaning that the are aligned even with less than 7 items, but when there are 8 or more, the width exceeds 100% and the parent container's flexbox squeezes them together, misaligning the weekdays from the dates.
Fixes part of vaadin/flow-components#6353
Related PR: vaadin/flow-components#6432
Type of change