refactor: support atypical whitespace in rte html value tags #6661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
tomivirkki
commented
Oct 17, 2023
| @@ -699,7 +699,7 @@ export const RichTextEditorMixin = (superClass) => | |||
| }; | |||
| // Replace whitespace characters with placeholders before the Delta conversion to prevent Quill from trimming them | |||
| Object.entries(whitespaceCharacters).forEach(([character, replacement]) => { | |||
| htmlValue = htmlValue.replaceAll(character, replacement); | |||
| htmlValue = htmlValue.replaceAll(/>[^<]*</gu, (match) => match.replaceAll(character, replacement)); // NOSONAR | |||
There was a problem hiding this comment.
The regex matches content only (tags are ignored):
web-padawan
approved these changes
Oct 17, 2023
tomivirkki
added a commit
that referenced
this pull request
Oct 17, 2023
tomivirkki
added a commit
that referenced
this pull request
Oct 17, 2023
tomivirkki
added a commit
that referenced
this pull request
Oct 17, 2023
This was referenced Oct 17, 2023
|
This ticket/PR has been released with Vaadin 24.3.0.alpha1 and is also targeting the upcoming stable 24.3.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One more improvement to the
<vaadin-rich-text-editor>HTML -> Delta conversion whitespace handling.This PR updates the logic to only match content outside HTML tags.
This is to allow unconventional, but still legal white space inside the HTML tags, for example (double-space between the tag name and the attribute):
Type of change
Bugfix