fix: prevent shadow from overlapping adjacent menu-bar-button#11130
Open
fix: prevent shadow from overlapping adjacent menu-bar-button#11130
Conversation
Contributor
There was a problem hiding this comment.
When I add theme="primary warning" to the dev page I still see the box shadows. Am I missing something?
Member
Author
There was a problem hiding this comment.
Hmm, I see it in Firefox as well. Maybe something wrong with that. I only tested it in Chrome 🙈
Contributor
There was a problem hiding this comment.
Yes, I was testing with Firefox
Contributor
There was a problem hiding this comment.
It seems that the issue is Firefox not having support for the style() with CSS custom properties. I noticed that the styles are not being applied at all.
Avoid style container query, which doesn't work in Firefox.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11126