refactor: update date-picker Escape logic to stop propagation #10477
+12
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomivirkki
approved these changes
Nov 12, 2025
DiegoCardoso
approved these changes
Nov 12, 2025
Co-authored-by: Tomi Virkki <tomivirkki@users.noreply.github.com>
|
Collaborator
|
This ticket/PR has been released with Vaadin 25.0.0-beta6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to vaadin/flow-components#8252
Type of change
Note
Note:
stopPropagation()is only called when overlay is opened, so in those cases thepreventDefault()added in #10360 might be unnecessary but for the closed overlay, it's probably better to keep it.