-
Notifications
You must be signed in to change notification settings - Fork 87
fix: ensure menu-bar buttons always have correct tabindex #10356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
94c5263 to
332aff8
Compare
332aff8 to
8e45b82
Compare
8e45b82 to
1b02619
Compare
b2316f9 to
07e8a24
Compare
07e8a24 to
a3e6a7e
Compare
|
|
Hi @web-padawan and @web-padawan, when i performed cherry-pick to this commit to 24.8, i have encountered the following issue. Can you take a look and pick it manually? |



Description
Fixes #10355
Currently,
vaadin-menu-barchecks for the first element withtabindex="0"in_setFocused()method. This doesn't work in cases when the button with this attribute gets hidden, especially an overflow button. Updated logic to always settabindexattribute on the overflow button at the same time ashiddenso they always stay in sync.In addition to the problem reported in the above issue, I also added a test for another similar case originating from the same root issue: pressing Shift + Tab caused two tab stops rather than one (unexpected if
tabNavigationisn't set).menu-bar-shift-tab.mp4
Type of change