feat: provide iconset import without iron-icon dependency #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split iconset definition from vaadin-icons.html into new iconset.html (which is then imported in vaadin-icons.html). This makes it so importing vaadin-icons.html works as before (and includes import of iron-icon) to maintain backwards compatibility, but now the developer also has the option to import the iconset without the iron-icon dependency by importing iconset.html directly. This is useful in some cases like when doing lazy asynchronous imports. Fixes #72
web-padawan
approved these changes
Mar 18, 2019
web-padawan
pushed a commit
to vaadin/web-components
that referenced
this pull request
Mar 3, 2021
vaadin/vaadin-icons#76 Split iconset definition from vaadin-icons.html into new iconset.html (which is then imported in vaadin-icons.html). This makes it so importing vaadin-icons.html works as before (and includes import of iron-icon) to maintain backwards compatibility, but now the developer also has the option to import the iconset without the iron-icon dependency by importing iconset.html directly. This is useful in some cases like when doing lazy asynchronous imports. Fixes: vaadin/vaadin-icons#72
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split iconset definition from vaadin-icons.html into new iconset.html (which is then imported in vaadin-icons.html).
This makes it so importing vaadin-icons.html works as before (and includes import of iron-icon) to maintain backwards compatibility, but now the developer also has the option to import the iconset without the iron-icon dependency by importing iconset.html directly. This is useful in some cases like when doing lazy asynchronous imports.
Fixes #72
This change is