Add fireShortcut method to ComponentTester for component-level keyboard shortcuts #1962
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
fireShortcut()
method to theComponentTester
class to enable testing of keyboard shortcuts attached directly to components through theKeyNotifier
interface methods.Problem
The existing
fireShortcut()
method inBaseUIUnitTest
only works with shortcuts attached to the UI (or modal components) created with theShortcuts
API. It does not work with key down listeners attached to individual components through theKeyNotifier
interface methods likeaddKeyDownListener()
.Solution
Added a new
fireShortcut(Key key, KeyModifier... modifiers)
method toComponentTester
that:ShortcutsKt._fireShortcut()
with the wrapped component as specified in the issueensureComponentIsUsable()
fireShortcut()
methodUsage Example
Implementation Details
ComponentTester
BaseUIUnitTest.fireShortcut()
Tests Added
Fixes #1748.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
maven.vaadin.com
/usr/lib/jvm/temurin-17-jdk-amd64/bin/java --enable-native-access=ALL-UNNAMED -classpath /usr/share/apache-maven-3.9.10/boot/plexus-classworlds-2.9.0.jar -Dclassworlds.conf=/usr/share/apache-maven-3.9.10/bin/m2.conf -Dmaven.home=/usr/share/apache-maven-3.9.10 -Dlibrary.jansi.path=/usr/share/apache-maven-3.9.10/lib/jansi-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/testbench/testbench org.codehaus.plexus.classworlds.launcher.Launcher clean compile -q
(dns block)/usr/lib/jvm/temurin-17-jdk-amd64/bin/java --enable-native-access=ALL-UNNAMED -classpath /usr/share/apache-maven-3.9.10/boot/plexus-classworlds-2.9.0.jar -Dclassworlds.conf=/usr/share/apache-maven-3.9.10/bin/m2.conf -Dmaven.home=/usr/share/apache-maven-3.9.10 -Dlibrary.jansi.path=/usr/share/apache-maven-3.9.10/lib/jansi-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/testbench/testbench org.codehaus.plexus.classworlds.launcher.Launcher clean compile -q -pl vaadin-testbench-unit-shared
(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.