Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add whitelisted-packages' docs URL to logs (#951) (CP: 12.4) #955

Merged
merged 1 commit into from
Dec 2, 2021
Merged

Add whitelisted-packages' docs URL to logs (#951) (CP: 12.4) #955

merged 1 commit into from
Dec 2, 2021

Conversation

vaadin-bot
Copy link
Collaborator

No description provided.

@vaadin-bot
Copy link
Collaborator Author

SonarQube analysis reported 18 issues

  • CRITICAL 5 critical
  • MAJOR 4 major
  • MINOR 9 minor

Top 10 issues

  1. CRITICAL VaadinServletContextInitializer.java#L176: Make "listeners" transient or serializable. rule
  2. CRITICAL VaadinServletContextInitializer.java#L763: Refactor this method to reduce its Cognitive Complexity from 21 to the 15 allowed. rule
  3. CRITICAL VaadinServletContextInitializer.java#L777: Refactor this code to not nest more than 3 if/for/while/switch/try statements. rule
  4. CRITICAL VaadinServletContextInitializer.java#L784: Refactor this code to not nest more than 3 if/for/while/switch/try statements. rule
  5. CRITICAL VaadinServletContextInitializer.java#L790: Refactor this code to not nest more than 3 if/for/while/switch/try statements. rule
  6. MAJOR VaadinServletContextInitializer.java#L219: Define and throw a dedicated exception instead of using a generic one. rule
  7. MAJOR VaadinServletContextInitializer.java#L381: Define and throw a dedicated exception instead of using a generic one. rule
  8. MAJOR VaadinServletContextInitializer.java#L450: Define and throw a dedicated exception instead of using a generic one. rule
  9. MAJOR VaadinServletContextInitializer.java#L499: Define and throw a dedicated exception instead of using a generic one. rule
  10. MINOR VaadinServletContextInitializer.java#L657: Move this method into "RouteServletContextListener". rule

@joheriks joheriks merged commit c1d92f4 into 12.4 Dec 2, 2021
@joheriks joheriks deleted the cherry-pick-951-to-12.4-1638428317617 branch December 2, 2021 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joheriks joheriks joheriks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vaadin-bot @joheriks @tarekoraby