-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: update to use dynamic imports for web components #210
Conversation
81915fb
to
cb4a97a
Compare
Tests for grid column fail with the following error related to recalculating column width:
Apparently, because of dynamic imports for custom columns, |
5818ef5
to
77a3b9f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #210 +/- ##
==========================================
+ Coverage 95.71% 97.39% +1.67%
==========================================
Files 30 30
Lines 280 345 +65
Branches 34 36 +2
==========================================
+ Hits 268 336 +68
Misses 2 2
+ Partials 10 7 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
2dcc352
to
6f244ee
Compare
4722b9a
to
ddf7d3a
Compare
ddf7d3a
to
edfca5b
Compare
Based on the internal discussion, we decided to proceed with #221 without adding dynamic imports. Closing this for now. |
Description
Related to #199
define()
helpers to force loading web components on demand.Type of change