-
Notifications
You must be signed in to change notification settings - Fork 68
refactor: form binder object models support #3816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3816 +/- ##
==========================================
+ Coverage 86.33% 86.72% +0.39%
==========================================
Files 123 129 +6
Lines 8474 8754 +280
Branches 1301 1350 +49
==========================================
+ Hits 7316 7592 +276
- Misses 1135 1139 +4
Partials 23 23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
|
d8833e8 to
37ff6dd
Compare
Addressed, the reviewer cannot accept.
Co-authored-by: Vlad Rindevich <vladrin@vaadin.com>
|
heruan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've completed an initial review of the changes. The new object model types and their reference implementations are clear, well documented, and thoroughly tested. Updates to existing logic and method signatures improve readability and semantics, and the use of deprecation notices preserver backwards compatibility where applicable.
There are a few Sonar issues worth addressing, as well as some previously unresolved review comments that still apply. Additionally, the branch currently has conflicts that need to be resolved, and some failing tests that should be investigated.




Fixes #3436