Skip to content

Conversation

@platosha
Copy link
Contributor

Fixes #3436

platosha added 28 commits August 4, 2025 16:56
@platosha platosha changed the title feat: object models support feat: form binder object models support Oct 6, 2025
@platosha platosha marked this pull request as ready for review October 6, 2025 07:23
@codecov
Copy link

codecov bot commented Oct 6, 2025

Codecov Report

❌ Patch coverage is 96.84385% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.72%. Comparing base (a46edfc) to head (8b880b9).

Files with missing lines Patch % Lines
packages/ts/lit-form/src/stringConverters.ts 82.35% 9 Missing ⚠️
packages/ts/lit-form/src/BinderNode.ts 95.65% 4 Missing and 2 partials ⚠️
packages/ts/models/src/m.ts 97.59% 2 Missing ⚠️
packages/ts/lit-form/src/StringConverter.ts 0.00% 1 Missing ⚠️
packages/ts/lit-form/src/Validation.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3816      +/-   ##
==========================================
+ Coverage   86.33%   86.72%   +0.39%     
==========================================
  Files         123      129       +6     
  Lines        8474     8754     +280     
  Branches     1301     1350      +49     
==========================================
+ Hits         7316     7592     +276     
- Misses       1135     1139       +4     
  Partials       23       23              
Flag Coverage Δ
unittests 86.72% <96.84%> (+0.39%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 7, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
3 Security Hotspots
54.8% Duplication on New Code (required ≤ 3%)
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Lodin
Lodin previously requested changes Oct 7, 2025
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ platosha
❌ Lodin
You have signed the CLA already but the status is still pending? Let us recheck it.

@platosha platosha force-pushed the feat/model-object-binder branch from d8833e8 to 37ff6dd Compare November 19, 2025 07:57
@mshabarov mshabarov requested a review from heruan November 19, 2025 12:28
@platosha platosha dismissed Lodin’s stale review November 20, 2025 07:35

Addressed, the reviewer cannot accept.

@platosha platosha changed the title feat: form binder object models support refactor: form binder object models support Nov 20, 2025
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
54.6% Duplication on New Code (required ≤ 3%)
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Copy link
Member

@heruan heruan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've completed an initial review of the changes. The new object model types and their reference implementations are clear, well documented, and thoroughly tested. Updates to existing logic and method signatures improve readability and semantics, and the use of deprecation notices preserver backwards compatibility where applicable.

There are a few Sonar issues worth addressing, as well as some previously unresolved review comments that still apply. Additionally, the branch currently has conflicts that need to be resolved, and some failing tests that should be investigated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Object Models] Binder support

5 participants