Drop stale migration references and GWT removal leftovers - #25216
Open
totally-not-ai[bot] wants to merge 1 commit into
Open
Drop stale migration references and GWT removal leftovers#25216totally-not-ai[bot] wants to merge 1 commit into
totally-not-ai[bot] wants to merge 1 commit into
Conversation
totally-not-ai
Bot
changed the title
Contributor
Artur-
force-pushed
the
flow-client-ts-cleanup-stale-refs
branch
from
August 14, 2026 07:59
a5ba6fc to
c6735d1
Compare
Artur-
changed the base branch from
flow-client-ts-console-gating
to
flow-server-remove-client-engine
August 14, 2026 08:01
totally-not-ai
Bot
force-pushed
the
flow-client-ts-cleanup-stale-refs
branch
from
August 16, 2026 09:48
c6735d1 to
bf2f491
Compare
totally-not-ai
Bot
changed the title
totally-not-ai
Bot
changed the title
totally-not-ai
Bot
changed the title
totally-not-ai
Bot
force-pushed
the
flow-client-ts-cleanup-stale-refs
branch
from
August 16, 2026 11:46
b2c830a to
98610ab
Compare
totally-not-ai
Bot
changed the title
totally-not-ai
Bot
changed the title
totally-not-ai
Bot
force-pushed
the
flow-client-ts-cleanup-stale-refs
branch
from
August 16, 2026 12:31
83382a8 to
1beb283
Compare
totally-not-ai
Bot
changed the title
totally-not-ai
Bot
force-pushed
the
flow-client-ts-cleanup-stale-refs
branch
from
August 16, 2026 18:17
1beb283 to
ef3efdb
Compare
totally-not-ai
Bot
changed the title
totally-not-ai
Bot
changed the title
totally-not-ai
Bot
force-pushed
the
flow-client-ts-cleanup-stale-refs
branch
from
August 17, 2026 10:51
ef3efdb to
66539d9
Compare
totally-not-ai
Bot
changed the title
totally-not-ai
Bot
changed the title
Follow-up to #25210. The port comments described work in progress -- "built alongside the Java version", "not ported yet", "contracts satisfied at cutover", constraints imposed by the HtmlUnit-based GwtTests, and $entry wrappers on the Java side -- none of which is true now that the GWT client is gone. publishClient still claimed it was "not yet wired into the bootstrap", pointing at a MIGRATION_STRATEGY.md that does not exist in the repository, and SimpleElementBindingStrategy said its functions would be assembled into a class that it already defines. Reword them to describe the code as it is, keeping the references to the GWT original where they explain why something looks the way it does. The "Slice N:" section headers, which numbered the migration steps, lose the numbering and keep their titles. Also remove what the GWT deletion left behind: the com/google/gwt/dev/js/globals resource, the gwt.version property and the gwt-elemental dependencyManagement entry in the root pom (no module depends on GWT any more), and ApplicationConstants.CLIENT_ENGINE_PATH, which named a folder that is no longer served or referenced. SessionCloseLogoutIT no longer allows console errors from the removed client engine path.
platosha
force-pushed
the
flow-client-ts-cleanup-stale-refs
branch
from
August 18, 2026 14:14
66539d9 to
f51a22e
Compare
totally-not-ai
Bot
changed the title
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #25210, which removed the GWT client. The comments left behind in the TypeScript client still described work in progress, and a few build/runtime artifacts of the GWT era were still around.
Comment rewording
The port comments in
flow-client/src/main/frontend/internal/**described the TS files as being "built alongside the Java version", listed things "not ported yet", promised "contracts satisfied at cutover", justified ES5 bundling with the HtmlUnit-basedGwtTests, and referred to callbacks arriving pre-wrapped in$entryfrom the Java side. None of that is true any more:publishClient.tsclaimed it was "not yet wired into the bootstrap" and pointed at aMIGRATION_STRATEGY.mdthat does not exist in the repository.SimpleElementBindingStrategy.tssaid its standalone functions would eventually be assembled into aBindingStrategy<Element>class — a class the same file already defines.ExecuteJavaScriptProcessor.tsdescribed$entryboundaries and ES5 bundling forGwtTests.The comments are reworded to describe the code as it actually is. References to the GWT original are kept where they explain why something looks the way it does (e.g. "TypeScript port of
com.vaadin.client.flow.binding.SimpleElementBindingStrategy"). TheSlice N:section headers, which numbered the migration steps, lose the numbering and keep their titles (--- closest-state-node lookups ---,--- attribute binding ---, and so on).GWT leftovers removed
com/google/gwt/dev/js/globals/firefox25.txt— an 872-line GWT compiler resource with nothing left to read it.gwt.versionproperty and thecom.google.gwt:gwt-elementaldependencyManagemententry in the rootpom.xml; no module depends on GWT any more.ApplicationConstants.CLIENT_ENGINE_PATH, which named aVAADIN/static/clientfolder that is no longer served or referenced anywhere.SessionCloseLogoutITno longer whitelists console errors from the removed client engine path; its filter now only allowsFlowClient.jsmessages.No functional change: comments, an unused resource, unused build configuration, and one unused constant.
API Changes
com.vaadin.flow.shared.ApplicationConstants