fix: Implement networkOnly.handle using cloned context with Edge #22975
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a timeout to the fetch request to prevent it from getting stuck indefinitely in Edge.
Refactor fetch handling to improve reliability in Edge.
TatuLund
changed the title
TatuLund
changed the title
|
Contributor
|
Seems like this fix is not needed as the latest version 143.0.3650.80 doesn't have the problem noted in the ticket. |
Contributor
|
@TatuLund do you think we can close this PR in favor of patch made in Edge? |
Contributor
Author
|
I would hope so. Lets follow-up few days if the need for this indeed has been deprecated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With cloned context Edge browser seems not to get stuck
Fixes #22954
See: https://github.com/WICG/service-worker-auto-preload?tab=readme-ov-file#how-it-works