Skip to content

Conversation

@mcollovati
Copy link
Collaborator

Migrates from unmaintained org.reflections library to actively maintained ClassGraph. Implements proper resource management using try-with-resources to prevent file handle leaks in large builds.

Fixes #19543

🤖 Generated with Claude Code

@github-actions
Copy link

github-actions bot commented Dec 11, 2025

Test Results

1 309 files  ± 0  1 309 suites  ±0   1h 15m 1s ⏱️ - 1m 10s
9 218 tests + 1  9 150 ✅ + 1  68 💤 ±0  0 ❌ ±0 
9 662 runs   - 15  9 587 ✅  - 15  75 💤 ±0  0 ❌ ±0 

Results for commit e04b2dc. ± Comparison against base commit 6351f76.

This pull request removes 1 and adds 2 tests. Note that renamed tests count towards both.
com.vaadin.flow.server.scanner.ReflectionsClassFinderTest ‑ reflections_notExistingDirectory_warningMessageNotLogged
com.vaadin.flow.server.scanner.ReflectionsClassFinderTest ‑ getAnnotatedClasses_findsRepeatableAnnotations
com.vaadin.flow.server.scanner.ReflectionsClassFinderTest ‑ notExistingDirectory_noExceptionThrown

♻️ This comment has been updated with latest results.

mcollovati and others added 4 commits December 18, 2025 08:39
Migrates from unmaintained org.reflections library to actively maintained
ClassGraph. Implements proper resource management using try-with-resources
to prevent file handle leaks in large builds.

Fixes #19543

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
javassist was pinned only to avoid conflicts with project
dependencies. It's a transitive dependency of reflections
library that is now replace by classgraph, that does not
need it.
@mcollovati mcollovati force-pushed the issues/19543-replace_reflections_with_classgraph branch from 434a8f1 to e04b2dc Compare December 18, 2025 07:39
@mcollovati mcollovati marked this pull request as ready for review December 18, 2025 07:39
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider switching from Reflections to a maintained library

2 participants