-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: queue message payloads #20749
feat: queue message payloads #20749
Conversation
5b7dfd6
to
8cf6097
Compare
e4a6e3e
to
0a9ae4d
Compare
0a9ae4d
to
7a97b9a
Compare
f7ff95f
to
998dfb5
Compare
Add sent payloads to message queue and resend if no response to message inside MaxMessageSuspendTimeout fixes #20507
Fix queued message send timing.
format server
Fix concurrent issue with custom uidl handler.
clear queue for push messaging.
f49e938
to
aefbb0a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still have to test manually. Added a few minor comments
flow-client/src/main/java/com/vaadin/client/communication/MessageSender.java
Outdated
Show resolved
Hide resolved
flow-client/src/main/java/com/vaadin/client/communication/MessageSender.java
Outdated
Show resolved
Hide resolved
flow-client/src/main/java/com/vaadin/client/communication/MessageSender.java
Outdated
Show resolved
Hide resolved
flow-client/src/main/java/com/vaadin/client/communication/MessageSender.java
Outdated
Show resolved
Hide resolved
flow-client/src/main/java/com/vaadin/client/communication/RequestResponseTracker.java
Outdated
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did some manual tests and the solution seems very robust.
Messages are always queued and resent in correct order.
Add sent payloads to message
queue and resend if no response
to message inside MaxMessageSuspendTimeout
fixes #20507