Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: queue message payloads #20749

Merged
merged 7 commits into from
Jan 13, 2025
Merged

feat: queue message payloads #20749

merged 7 commits into from
Jan 13, 2025

Conversation

caalador
Copy link
Contributor

Add sent payloads to message
queue and resend if no response
to message inside MaxMessageSuspendTimeout

fixes #20507

Copy link

github-actions bot commented Dec 19, 2024

Test Results

1 160 files  +1  1 160 suites  +1   1h 34m 46s ⏱️ + 2m 38s
7 585 tests +2  7 529 ✅ +2  56 💤 ±0  0 ❌ ±0 
7 920 runs   - 3  7 857 ✅  - 1  63 💤  - 2  0 ❌ ±0 

Results for commit c604efb. ± Comparison against base commit 4688eb1.

♻️ This comment has been updated with latest results.

@caalador caalador force-pushed the issues/20507-client-queue branch 7 times, most recently from 5b7dfd6 to 8cf6097 Compare December 23, 2024 08:56
@caalador caalador force-pushed the issues/20507-client-queue branch 8 times, most recently from e4a6e3e to 0a9ae4d Compare January 8, 2025 12:00
@caalador caalador marked this pull request as ready for review January 8, 2025 12:06
@caalador caalador force-pushed the issues/20507-client-queue branch from 0a9ae4d to 7a97b9a Compare January 9, 2025 05:06
@vaadin-bot vaadin-bot added +1.0.0 and removed +0.0.1 labels Jan 10, 2025
@caalador caalador force-pushed the issues/20507-client-queue branch 5 times, most recently from f7ff95f to 998dfb5 Compare January 10, 2025 09:56
Add sent payloads to message
queue and resend if no response
to message inside MaxMessageSuspendTimeout

fixes #20507
Fix queued message send timing.
Fix concurrent issue with custom uidl handler.
@caalador caalador force-pushed the issues/20507-client-queue branch from f49e938 to aefbb0a Compare January 13, 2025 05:44
@vaadin-bot vaadin-bot added +0.0.1 and removed +1.0.0 labels Jan 13, 2025
Copy link
Collaborator

@mcollovati mcollovati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still have to test manually. Added a few minor comments

Copy link
Collaborator

@mcollovati mcollovati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did some manual tests and the solution seems very robust.
Messages are always queued and resent in correct order.

@mshabarov mshabarov merged commit d2f9ee0 into main Jan 13, 2025
26 checks passed
@mshabarov mshabarov deleted the issues/20507-client-queue branch January 13, 2025 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Client to queue request messages to server and resend them when needed
4 participants