Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add drag image for DragSource #20098

Merged
merged 6 commits into from
Oct 2, 2024
Merged

feat: add drag image for DragSource #20098

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
05435cc
feat: add drag image for DragSource
tltv Sep 30, 2024
d54baf9
chore: removed unnecessary dependency
tltv Oct 1, 2024
34cfffd
chore: cleanup tests
tltv Oct 1, 2024
917814d
chore: update link in Javadoc
tltv Oct 1, 2024
b26006d
Merge branch 'main' into feat/6793-drag-image
mcollovati Oct 2, 2024
211ec8a
Merge branch 'main' into feat/6793-drag-image
mcollovati Oct 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: update link in Javadoc
  • Loading branch information
@tltv
tltv committed Oct 1, 2024
commit 917814d8b0c29eabb1d1f3f954e9db157016cb0b
4 changes: 2 additions & 2 deletions flow-dnd/src/main/java/com/vaadin/flow/component/dnd/DragSource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,7 @@ default EffectAllowed getEffectAllowed() {
* image is shown by default with zero offset which means that pointer
* location is in the top left corner of the image.
* <p>
* {@link com.vaadin.flow.component.html.Image} is fully supported as a drag
* {@code com.vaadin.flow.component.html.Image} is fully supported as a drag
* image component. Other components can be used as well, but the support
* may vary between browsers. If given component is visible element in the
* viewport, browser can show it as a drag image.
Expand All @@ -328,7 +328,7 @@ default void setDragImage(Component dragImage) {
* Coordinates define the offset of the pointer location from the top left
* corner of the image.
* <p>
* {@link com.vaadin.flow.component.html.Image} is fully supported as a drag
* {@code com.vaadin.flow.component.html.Image} is fully supported as a drag
* image component. Other components can be used as well, but the support
* may vary between browsers. If given component is visible element in the
* viewport, browser can show it as a drag image.
Expand Down
Loading