test: increase sleep time to allow GC to perform cleanup #20019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On CI system the test randomly fails because the GC seems not to clean up ComponentLocator memory within the 5 seconds. However, running the test in isolation works fine. This change increases the delay between the GC requests to try to make the test more reliable.
caalador
reviewed
Sep 23, 2024
flow-server/src/test/java/com/vaadin/flow/ComponentTrackerTest.java
Outdated
Show resolved
Hide resolved
flow-server/src/test/java/com/vaadin/flow/ComponentTrackerTest.java
Outdated
Show resolved
Hide resolved
|
caalador
approved these changes
Sep 23, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
Sep 23, 2024
On CI system the test randomly fails because the GC seems not to clean up ComponentLocator memory within the 5 milliseconds. However, running the test in isolation works fine. This change increases the delay between the GC requests to try to make the test more reliable.
vaadin-bot
pushed a commit
that referenced
this pull request
Sep 23, 2024
On CI system the test randomly fails because the GC seems not to clean up ComponentLocator memory within the 5 milliseconds. However, running the test in isolation works fine. This change increases the delay between the GC requests to try to make the test more reliable.
vaadin-bot
pushed a commit
that referenced
this pull request
Sep 23, 2024
On CI system the test randomly fails because the GC seems not to clean up ComponentLocator memory within the 5 milliseconds. However, running the test in isolation works fine. This change increases the delay between the GC requests to try to make the test more reliable.
vaadin-bot
added a commit
that referenced
this pull request
Sep 23, 2024
…0022) On CI system the test randomly fails because the GC seems not to clean up ComponentLocator memory within the 5 milliseconds. However, running the test in isolation works fine. This change increases the delay between the GC requests to try to make the test more reliable. Co-authored-by: Marco Collovati <marco@vaadin.com>
vaadin-bot
added a commit
that referenced
this pull request
Sep 23, 2024
…0023) On CI system the test randomly fails because the GC seems not to clean up ComponentLocator memory within the 5 milliseconds. However, running the test in isolation works fine. This change increases the delay between the GC requests to try to make the test more reliable. Co-authored-by: Marco Collovati <marco@vaadin.com>
vaadin-bot
added a commit
that referenced
this pull request
Sep 23, 2024
…0021) On CI system the test randomly fails because the GC seems not to clean up ComponentLocator memory within the 5 milliseconds. However, running the test in isolation works fine. This change increases the delay between the GC requests to try to make the test more reliable. Co-authored-by: Marco Collovati <marco@vaadin.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On CI systems the test randomly fails because the GC seems not to clean up ComponentLocator memory within the 5 milliseconds. However, running the test in isolation works fine. This change increases the delay between the GC requests to try to make the test more reliable.