fix: fail fast if view defines same path for route and route alias #19977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caalador
previously approved these changes
Sep 18, 2024
flow-server/src/main/java/com/vaadin/flow/server/startup/AbstractRouteRegistryInitializer.java
Outdated
Show resolved
Hide resolved
|
caalador
approved these changes
Sep 18, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
Sep 18, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
Sep 18, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
Sep 18, 2024
vaadin-bot
added a commit
that referenced
this pull request
Sep 18, 2024
vaadin-bot
added a commit
that referenced
this pull request
Sep 18, 2024
vaadin-bot
added a commit
that referenced
this pull request
Sep 18, 2024
|
This ticket/PR has been released with Vaadin 24.5.0.beta2 and is also targeting the upcoming stable 24.5.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if a view defines
@Routeand@RouteAliaswith the same path, the alias is rejected at startup, but there is no evidence of the error.However, when hot swap is enabled and the view class is reloaded, an exception is thrown.
This change adds an explicit check for duplicate paths, preventing the application from starting if the configuration is invalid.
Fixes #19972