Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent runWhenAttached command to execute immediately by detach listeners #18997

Merged
merged 1 commit into from
Mar 22, 2024
Merged

fix: prevent runWhenAttached command to execute immediately by detach listeners #18997

merged 1 commit into from
Mar 22, 2024

Conversation

mcollovati
Copy link
Collaborator

Fixes #18983

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

Test Results

1 089 files  ± 0  1 089 suites  ±0   1h 21m 15s ⏱️ +18s
6 913 tests + 1  6 864 ✅ + 1  49 💤 ±0  0 ❌ ±0 
7 233 runs   - 38  7 174 ✅  - 36  59 💤  - 2  0 ❌ ±0 

Results for commit 7dd02d9. ± Comparison against base commit 867825c.

@mcollovati mcollovati requested a review from sissbruecker March 20, 2024 10:14
sissbruecker
sissbruecker approved these changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@sissbruecker sissbruecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with the reproduction from the issue and can confirm that it fixes the problem

@tltv tltv self-requested a review March 22, 2024 09:14
@tltv tltv merged commit 6c1e927 into main Mar 22, 2024
26 checks passed
@tltv tltv deleted the issues/18983_runWhenAttached_child_nodes branch March 22, 2024 10:12
vaadin-bot pushed a commit that referenced this pull request Mar 22, 2024
@mcollovati @vaadin-bot
fix: prevent runWhenAttached command to execute immediately by detach…
886e862 
… listeners (#18997)

Fixes #18983
vaadin-bot pushed a commit that referenced this pull request Mar 22, 2024
@mcollovati @vaadin-bot
fix: prevent runWhenAttached command to execute immediately by detach…
fe06704 
… listeners (#18997)

Fixes #18983
vaadin-bot added a commit that referenced this pull request Mar 22, 2024
@vaadin-bot @mcollovati
fix: prevent runWhenAttached command to execute immediately by detach…
5410f66 
… listeners (#18997) (#19015)

Fixes #18983

Co-authored-by: Marco Collovati <marco@vaadin.com>
vaadin-bot added a commit that referenced this pull request Mar 22, 2024
@vaadin-bot @mcollovati
fix: prevent runWhenAttached command to execute immediately by detach…
c4c1067 
… listeners (#18997) (#19016)

Fixes #18983

Co-authored-by: Marco Collovati <marco@vaadin.com>
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.4.0.alpha17 and is also targeting the upcoming stable 24.4.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sissbruecker sissbruecker sissbruecker approved these changes

@tltv tltv tltv approved these changes

Assignees
No one assigned
Labels
cherry-picked-23.5 cherry-picked-24.3 prerelease version for Vaadin 24.4.0 Released with Vaadin 24.4.0.alpha17 target/23.5 target/24.3 +0.0.1
Projects
Vaadin Flow ongoing work (Vaadin 10+)
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Grid-Component : Errors with Drag-And-Drop and Item-Selection
4 participants
@mcollovati @vaadin-bot @sissbruecker @tltv