fix: update JWT cookie at every request #18994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes stateless authentication, by updating the JWT cookies at every request, preventing the browser to remove the cookie after initial max-age time is expired. Fixes #18880
|
Tested the change also with Hilla integration test |
Test Results1 091 files + 1 1 091 suites +1 1h 24m 50s ⏱️ + 2m 47s Results for commit 52de1f8. ± Comparison against base commit 94b2560. This pull request removes 1 and adds 7 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
|
Removed workaround for spring-projects/spring-security#12579 since it has been fixed. |
mshabarov
requested changes
Mar 25, 2024
| @@ -84,18 +97,32 @@ public final class VaadinStatelessSecurityConfigurer<H extends HttpSecurityBuild | |||
|
|
|||
| private SecretKeyConfigurer secretKeyConfigurer; | |||
|
|
|||
| public void setSharedObjects(HttpSecurity http) { | |||
There was a problem hiding this comment.
This method is public in a public class. Maybe it's better to deprecate it, rather than remove?
There was a problem hiding this comment.
Make sense. I'll change it
| @@ -84,18 +97,32 @@ public final class VaadinStatelessSecurityConfigurer<H extends HttpSecurityBuild | |||
|
|
|||
| private SecretKeyConfigurer secretKeyConfigurer; | |||
|
|
|||
| public void setSharedObjects(HttpSecurity http) { | |||
| public static void apply(HttpSecurity http, | |||
|
Tested the |
|
mshabarov
approved these changes
Mar 25, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
Mar 25, 2024
* fix: update JWT cookie at every request Fixes stateless authentication, by updating the JWT cookies at every request, preventing the browser to remove the cookie after initial max-age time is expired. Fixes #18880 * apply review suggestions --------- Co-authored-by: Mikhail Shabarov <61410877+mshabarov@users.noreply.github.com>
vaadin-bot
added a commit
that referenced
this pull request
Mar 25, 2024
* fix: update JWT cookie at every request Fixes stateless authentication, by updating the JWT cookies at every request, preventing the browser to remove the cookie after initial max-age time is expired. Fixes #18880 * apply review suggestions --------- Co-authored-by: Marco Collovati <marco@vaadin.com> Co-authored-by: Mikhail Shabarov <61410877+mshabarov@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes stateless authentication, by updating the JWT cookies at every request, preventing the browser to remove the cookie after initial max-age time is expired.
Fixes #18895
Type of change
Checklist
Additional for
Featuretype of change