Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix paths for temp files in tests #18985

Merged
merged 6 commits into from
Mar 20, 2024
Merged

Conversation

caalador
Copy link
Contributor

No temporary test files should
be generated into the project folder.

No temporary test files should
be generated into the project folder.
Copy link

github-actions bot commented Mar 19, 2024

Test Results

1 089 files  ± 0  1 089 suites  ±0   1h 26m 8s ⏱️ + 5m 11s
6 912 tests ± 0  6 863 ✅ ± 0  49 💤 ±0  0 ❌ ±0 
7 252 runs   - 19  7 191 ✅  - 19  61 💤 ±0  0 ❌ ±0 

Results for commit c3a857b. ± Comparison against base commit 867825c.

♻️ This comment has been updated with latest results.

@mcollovati
Copy link
Collaborator

Looks good. I can still see a config/needs-build generated on module root, but I have not figured out which test is creating it.

@mcollovati
Copy link
Collaborator

It looks like it is NodeTasksHillaTest that writes config/needs-build in module root and does not clean it.

@caalador
Copy link
Contributor Author

I'll check and fix that also

@vaadin-bot vaadin-bot added +1.0.0 and removed +0.0.1 labels Mar 20, 2024
@mcollovati
Copy link
Collaborator

It seems that FrontendResourcesAreCopiedAfterCleaningTest also writes the config/needs-build on module root.
It should be the last one.

@vaadin-bot vaadin-bot added +0.0.1 and removed +1.0.0 labels Mar 20, 2024
mcollovati
mcollovati previously approved these changes Mar 20, 2024
@mcollovati mcollovati enabled auto-merge (squash) March 20, 2024 11:21
@mcollovati mcollovati disabled auto-merge March 20, 2024 11:28
@mcollovati mcollovati enabled auto-merge (squash) March 20, 2024 11:28
Copy link

Quality Gate Passed Quality Gate passed

Issues
9 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@mcollovati mcollovati merged commit e2555ca into main Mar 20, 2024
25 of 26 checks passed
@mcollovati mcollovati deleted the test/fix-temp-test-files branch March 20, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants