-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Vaadin command interceptor #17738
Draft
marcingrzejszczak
wants to merge
10
commits into
vaadin:main
Choose a base branch
from
marcingrzejszczak:vaadinCommandInterceptor
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
feat: Vaadin command interceptor #17738
marcingrzejszczak
wants to merge
10
commits into
vaadin:main
from
marcingrzejszczak:vaadinCommandInterceptor
Commits on Sep 15, 2023
-
Adds a VaadinFilter abstraction
VaadinFilter simulates an around aspect around processing of a request related to vaadingh-17436
Configuration menu - View commit details
-
Copy full SHA for f04596e - Browse repository at this point
Copy the full SHA f04596eView commit details -
Reuse Vaadin's Lookup mechanism
* renamed VaadinFilter to VaadinRequestInterceptor * Vaadin uses Lookup to init the VaadinService ** Added VaadinRequestInterceptors to ServiceInitEvent ** Added a VaadinRequestInterceptorServiceInitListener that will add interceptors to the init event ** The listener works with ServiceLocator based DI and Spring based DI (has both arg and non-arg constructor) ** That way we have 1 way of initializing the interceptors * Added the VaadinRequestInterceptorServiceInitListener to META-INF for automated locator discovery * Added the VaadinRequestInterceptorServiceInitListener as a bean for Spring Boot auto configuration * Extended the Instantiator mechanism to find all instances of a given class ** Implemented the method in Spring and non-Spring implementations
Configuration menu - View commit details
-
Copy full SHA for 1d076f7 - Browse repository at this point
Copy the full SHA 1d076f7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6a80771 - Browse repository at this point
Copy the full SHA 6a80771View commit details -
Apply suggestions from code review
Co-authored-by: Mikhail Shabarov <61410877+mshabarov@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for e604e60 - Browse repository at this point
Copy the full SHA e604e60View commit details -
Configuration menu - View commit details
-
Copy full SHA for 15c727f - Browse repository at this point
Copy the full SHA 15c727fView commit details
Commits on Sep 28, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 8fda3ac - Browse repository at this point
Copy the full SHA 8fda3acView commit details -
Configuration menu - View commit details
-
Copy full SHA for d3a6827 - Browse repository at this point
Copy the full SHA d3a6827View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3ace8e8 - Browse repository at this point
Copy the full SHA 3ace8e8View commit details
Commits on Sep 29, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 93f22fe - Browse repository at this point
Copy the full SHA 93f22feView commit details
Commits on Oct 23, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 9b5d2c3 - Browse repository at this point
Copy the full SHA 9b5d2c3View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.