Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for template matching in MenuRegistry#hasClientRoute(String) #20268

Open
tltv opened this issue Oct 16, 2024 · 0 comments · May be fixed by #20284
Open

Add support for template matching in MenuRegistry#hasClientRoute(String) #20268

tltv opened this issue Oct 16, 2024 · 0 comments · May be fixed by #20284
Assignees
@tltv

Comments

@tltv
Copy link
Member

tltv commented Oct 16, 2024

Add template support in MenuRegistry#hasClientRoute(String) to make DefaultRouteResolver detect main layout for client routes with route parameters.

This is followup from comment here in #20261. More details and test app there.
@tltv tltv mentioned this issue Oct 16, 2024
Open
@tltv tltv self-assigned this Oct 18, 2024
tltv added a commit that referenced this issue Oct 18, 2024
@tltv
fix: support client route parameters in auto layout path matching
173766a 
Improves navigation path matching with client route templates. Adds support for matching with route parameters to find automatic Flow main layout for client routes.

Fixes: #20268
@tltv tltv linked a pull request Oct 18, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tltv tltv

Labels
None yet
Projects
Vaadin Flow ongoing work (Vaadin 10+)
Status: ⚒️ In progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: support client route parameters in auto layout path matching vaadin/flow
1 participant
@tltv