Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vaadin Flow 24.4.0.alpha4 RouterLink in Drawer #18736

Closed
Tracked by #5012
alexanoid opened this issue Feb 17, 2024 · 0 comments · Fixed by #18801
Closed
Tracked by #5012

Vaadin Flow 24.4.0.alpha4 RouterLink in Drawer #18736

alexanoid opened this issue Feb 17, 2024 · 0 comments · Fixed by #18801
Assignees
@tepi
Labels
bug Impact: High Severity: Major

Comments

@alexanoid
Copy link

Description of the bug

With 24.4.0.alpha4, when I click on the RouterLink which points to the page where I currently am, the Drawer on the mobile view does not close, unlike in version 24.4.0.alpha2:

drawer

Expected behavior

The drawer on the mobile view should be closed after the click, even if it is pointed to the page where the user currently is

Minimal reproducible example

n/a

Versions

  • Vaadin / Flow version: 24.4.0.alpha4
@alexanoid alexanoid mentioned this issue Feb 17, 2024
Closed
@tepi tepi self-assigned this Feb 20, 2024
@tepi tepi mentioned this issue Feb 26, 2024
Merged
caalador pushed a commit that referenced this issue Feb 27, 2024
@tepi
fix: fire location-changed on popstateevent (#18801)
068ef10 
Fixes #18736
@ZheSun88 ZheSun88 mentioned this issue Feb 27, 2024
Open
This was referenced Aug 19, 2024
Open
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tepi tepi

Labels
bug Impact: High Severity: Major
Projects
Vaadin Flow bugs & maintenance (Vaadin 10+)
Status: ✅ Closed
Vaadin Flow ongoing work (Vaadin 10+)
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: fire location-changed on popstateevent vaadin/flow
3 participants
@tepi @mshabarov @alexanoid