Skip to content

Commit

Permalink
feat: Upgrade to React 19 rc
Browse files Browse the repository at this point in the history
  • Loading branch information
Artur- committed Jun 27, 2024
1 parent 0908779 commit 71bd5e7
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -981,6 +981,7 @@ private List<String> getNpmExecutable(boolean removePnpmLock) {
returnCommand.add("--no-update-notifier");
returnCommand.add("--no-audit");
returnCommand.add("--scripts-prepend-node-path=true");
returnCommand.add("--legacy-peer-deps");

if (removePnpmLock) {
// remove pnpm-lock.yaml which contains pnpm as a dependency.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@
"author": "",
"license": "Apache-2.0",
"dependencies": {
"react": "18.3.1",
"react-dom": "18.3.1",
"react": "19.0.0-rc-3563387fe3-20240621",
"react-dom": "19.0.0-rc-3563387fe3-20240621",
"react-router-dom": "6.23.1"
},
"devDependencies": {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -417,7 +417,7 @@ public void homeNodeIsNotForced_useGlobalNode()
not(containsString(vaadinHomeDir)));
assertThat(tools.getNodeExecutable(), not(containsString(baseDir)));

assertEquals(4, tools.getNpmExecutable().size());
assertEquals(5, tools.getNpmExecutable().size());
assertThat(tools.getNpmExecutable().get(0), containsString("npm"));
assertThat(tools.getNpmExecutable().get(1),
containsString("--no-update-notifier"));
Expand Down

0 comments on commit 71bd5e7

Please sign in to comment.