-
Notifications
You must be signed in to change notification settings - Fork 72
refactor: remove custom I18N merging logic #7971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
* files/event handlers for every possible state. | ||
*/ | ||
@Test | ||
public void testFullI18nShouldOverrideCompleteConfigurationInWebComponentProperty() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These tests were checking that the nested I18N structure was properly merged by the executeJs
call that has now been removed. The equivalent would now be to check the internal __effectiveI18n
property.
However, since the merging logic is part of the web component, I think it's better to remove this. The web components could use some better test coverage for partial I18n, but that's a separate issue.
|
Should this also change similar logic in |
Thanks, I missed those. Turns out the partial I18n mechanism was missing for MSCB, so I created a PR for this first: vaadin/web-components#10147 The tests for those components will also need to be changed as they make assertions on the |
Description
Removes custom logic for merging I18N values from Flow components with web components defaults. That should now be covered by all web components having support for setting partial I18N objects.
Type of change