Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "refactor!: extract auto add behavior into controller (#6620)" #6639

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

sissbruecker
Copy link
Contributor

Reverts the refactoring for extracting the auto add behavior, as it causes a regression where closing an auto-added dialog results in a Javascript error (vaadin/flow#19954).

@sissbruecker sissbruecker enabled auto-merge (squash) September 13, 2024 12:16
Copy link

sonarcloud bot commented Sep 13, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
24.4% Duplication on New Code (required ≤ 10%)

See analysis details on SonarCloud

@sissbruecker sissbruecker merged commit 40e489f into main Sep 13, 2024
3 of 5 checks passed
@sissbruecker sissbruecker deleted the revert/extract-overlay-auto-add-controller branch September 13, 2024 12:58
vursen pushed a commit that referenced this pull request Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants