feat(ConfirmDialog): add setter/getter for aria-describedby #4913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
vursen
reviewed
May 12, 2023
...confirm-dialog-flow/src/main/java/com/vaadin/flow/component/confirmdialog/ConfirmDialog.java
Outdated
Show resolved
Hide resolved
...confirm-dialog-flow/src/main/java/com/vaadin/flow/component/confirmdialog/ConfirmDialog.java
Outdated
Show resolved
Hide resolved
…rc/main/java/com/vaadin/flow/component/confirmdialog/ConfirmDialog.java Co-authored-by: Sergey Vinogradov <mr.vursen@gmail.com>
vursen
previously approved these changes
May 15, 2023
...confirm-dialog-flow/src/main/java/com/vaadin/flow/component/confirmdialog/ConfirmDialog.java
Outdated
Show resolved
Hide resolved
...confirm-dialog-flow/src/main/java/com/vaadin/flow/component/confirmdialog/ConfirmDialog.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Sergey Vinogradov <mr.vursen@gmail.com>
vursen
reviewed
May 15, 2023
...confirm-dialog-flow/src/main/java/com/vaadin/flow/component/confirmdialog/ConfirmDialog.java
Outdated
Show resolved
Hide resolved
vursen
reviewed
May 15, 2023
...confirm-dialog-flow/src/main/java/com/vaadin/flow/component/confirmdialog/ConfirmDialog.java
Outdated
Show resolved
Hide resolved
…rc/main/java/com/vaadin/flow/component/confirmdialog/ConfirmDialog.java Co-authored-by: Sergey Vinogradov <mr.vursen@gmail.com>
vursen
approved these changes
May 15, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
|
This ticket/PR has been released with Vaadin 24.1.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add API to override the default
aria-describedbyvalue set by the web component.Blocked by vaadin/web-components#5728
Blocked by vaadin/web-components#5730
Fixes vaadin/web-components#4684
Type of change