Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix NPE if component renderer returns null #4361

Merged

Commits on Dec 15, 2022

  1. fix: Fix NPE if component renderer returns null

    Users (including myself couple of times) intuitively return null for e.g. Grid cells that
    shouldn't contain component and consider this a bug. It is common that only some
    rows contain e.g. an edit button (for example based on permissions).
    
    Currently we throw a nasty NPE from the internals. With this simple fix we do a null
    check instead and render nothing.
    mstahv committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    2778452 View commit details
    Browse the repository at this point in the history
  2. fixed test

    mstahv committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    71b7972 View commit details
    Browse the repository at this point in the history
  3. Alternative solution

    mstahv committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    f75d955 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    739e8be View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2022

  1. use Text instead of Div

    mstahv committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    f8f3b90 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8a7fa4a View commit details
    Browse the repository at this point in the history