Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: disabled items can now be part of a CheckboxGroup's valid value (#1903) (CP: 20.0) #1968

Merged
merged 2 commits into from
Aug 3, 2021
Merged

fix: disabled items can now be part of a CheckboxGroup's valid value (#1903) (CP: 20.0) #1968

merged 2 commits into from
Aug 3, 2021

Conversation

vaadin-bot
Copy link
Collaborator

No description provided.

sosa-vaadin and others added 2 commits August 2, 2021 11:16
@sosa-vaadin @sissbruecker
@alvarezguille @ZheSun88
fix: disabled items can now be part of a CheckboxGroup's valid value (#…
f655e0c 
…1903)

Co-authored-by: Sascha Ißbrücker <sascha.issbruecker@googlemail.com>
Co-authored-by: Guille <alvarezguille@users.noreply.github.com>
@alvarezguille
Merge branch '20.0' into cherry-pick-1903-to-20.0-1627892202901
b3f2769
@alvarezguille alvarezguille enabled auto-merge (squash) August 3, 2021 08:26
@alvarezguille alvarezguille merged commit f136532 into 20.0 Aug 3, 2021
@alvarezguille alvarezguille deleted the cherry-pick-1903-to-20.0-1627892202901 branch August 3, 2021 08:29
@vaadin-bot
Copy link
Collaborator Author

SonarQube analysis reported 13 issues

  • CRITICAL 2 critical
  • MAJOR 1 major
  • MINOR 7 minor
  • INFO 3 info

Top 10 issues

  1. CRITICAL CheckboxGroup.java#L178: Make "item" transient or serializable. rule
  2. CRITICAL CheckboxGroup.java#L286: Remove usage of generic wildcard type. rule
  3. MAJOR CheckboxGroup.java#L611: Rename "dataProvider" which hides the field declared at line 83. rule
  4. MINOR CheckboxGroup.java#L112: Remove this use of "setDataProvider"; it is deprecated. rule
  5. MINOR CheckboxGroup.java#L138: Remove this use of "setDataProvider"; it is deprecated. rule
  6. MINOR CheckboxGroup.java#L157: Remove this use of "getDataProvider"; it is deprecated. rule
  7. MINOR CheckboxGroup.java#L171: Remove this use of "getDataProvider"; it is deprecated. rule
  8. MINOR CheckboxGroup.java#L432: Remove this use of "getDataProvider"; it is deprecated. rule
  9. MINOR CheckboxGroup.java#L472: Remove this use of "getDataProvider"; it is deprecated. rule
  10. MINOR CheckboxGroup.java#L611: Remove this use of "getDataProvider"; it is deprecated. rule

@vaadin-bot
Copy link
Collaborator Author

This ticket/PR has been released with platform 20.0.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvarezguille alvarezguille alvarezguille approved these changes

Assignees
No one assigned
Labels
Released with Platform 20.0.6
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vaadin-bot @alvarezguille @sosa-vaadin