docs: update notification examples to support both Lumo and Aura#5228
docs: update notification examples to support both Lumo and Aura#5228web-padawan merged 5 commits intomainfrom
Conversation
| // tag::snippet[] | ||
|
|
||
|
|
||
| // tag::snippet[] |
There was a problem hiding this comment.
Duplicate snippet start
| {/* tag::snippet[] */} | ||
| <Notification | ||
| theme="contrast" | ||
| theme="warning" |
There was a problem hiding this comment.
Making this a warning feels a bit off, as the notification here would just be displayed as intented, it's not an exceptional occurrence. Maybe just use the default variant.
| <!-- tag::snippet[] --> | ||
| <vaadin-notification | ||
| theme="contrast" | ||
| theme="warning" |
There was a problem hiding this comment.
For the best practices examples, was there a technical limitation on why we can't have the theme switcher there? IMO not so relevant to be able to switch themes in those, but it feels a bit inconsistent at first.
There was a problem hiding this comment.
Added theme switcher and updated examples to use horizontal layout to make them look better in Aura.
| |Lumo | ||
| |Lumo, Aura | ||
|
|
||
| |`info` |
There was a problem hiding this comment.
Is there any benefit to still listing primary? I assume info should be used instead from now on?
There was a problem hiding this comment.
Makes sense. Removed mention of "primary".
web-padawan
force-pushed
the
docs/notification-replace-lumo
branch
from
7df1fb4 to
1bbbb87
Compare
2 participants
LUMO_variants with new unprefixed variants that are supported in Auramarginwithslot="end"to make buttons in notifications look bettermin-widthon layouts to add space between text and buttons in Lumotertiary-inlinevariant from buttons in notification examplesnotifications-popupexample - replaced ContextMenu with Popovernotification-richexample (last notification didn't look good in Aura)notifications-popupexample using badge