Skip to content

Conversation

@tltv
Copy link
Member

@tltv tltv commented Oct 10, 2025

Removed production profile from articles that use example apps that build or will build production package without any production profile.

Part of vaadin/flow#22464

WIP: starters are not updated yet and they are pending on new Spring Boot 4 release that enables removal of the production profile.

Removed production profile from articles that use example apps that build or will build production package without any production profile.

Part of vaadin/flow#22464
@github-actions
Copy link

github-actions bot commented Oct 10, 2025

AI Language Review

  • In the Build a Project section, the instructions for making a production build have changed the activation from the production profile to the package goal. Ensure that end users understand that in the new process, they don't need to activate a profile to build for production.
  • For the Building with Commercial Components section, verify that the change from package -Pproduction to clean package applies correctly to this context. Since commercial components might require specific handling, ensure that the provided instructions are adequate for both scenarios.
  • In the Deploying Using Docker section, the steps for creating a production build of a Vaadin application have also replaced clean package -Pproduction with clean package. Confirm if this modification aligns with the deployment requirements on Docker.
  • In the Production Build section, ensure that the explanation about how to set up the vaadin-maven-plugin for manually created pom.xml files correctly reflects the necessary setup to substitute the previous production profile approach.
  • Check whether the language transition presents potential misunderstandings about the criteria for production builds, especially in the Enabling Production Builds and Excluding Development Server Module instructions. Readers who previously relied on using the production profile may need clarification.
  • For the Known Issues section in the Quarkus documentation, confirm that reference adjustments such as BOM positioning in the pom.xml are sufficiently clear, especially when dealing with conflicts between Vaadin and Quarkus BOM positioning.

@mshabarov mshabarov self-requested a review October 20, 2025 11:35
Copy link
Contributor

@mshabarov mshabarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Couple of non-blocking comments.

Comment on lines +202 to +218
Or when building Spring Boot 4 application, add `vaadin-dev` dependency as a `optional` scope in project `<dependencies>`. Spring Boot 4 `spring-boot-maven-plugin` automatically excludes optional dependencies from the final build:

.`pom.xml`
[source,xml]
----
<dependencies>
...
<dependency>
<groupId>com.vaadin</groupId>
<artifactId>vaadin-dev</artifactId>
<optional>true</optional>
</dependency>
...
</dependencies>
----


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd move this snippet to up (before a snippet with profile) so as to make it a primary recommended way for spring apps.

mvn clean package
----

For other applications, e.g., Jakarta EE or plain Java, and for better backwards compatibility, run same with a production profile:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be easier to read if this can give a link to the fragment where the production profile is defined.

@mshabarov mshabarov marked this pull request as ready for review October 27, 2025 11:20
@mshabarov mshabarov merged commit 373385f into main Oct 27, 2025
4 checks passed
@mshabarov mshabarov deleted the docs/build-for-production-by-default branch October 27, 2025 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants