-
Couldn't load subscription status.
- Fork 213
docs: update articles for production build change #4650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Removed production profile from articles that use example apps that build or will build production package without any production profile. Part of vaadin/flow#22464
AI Language Review
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Couple of non-blocking comments.
| Or when building Spring Boot 4 application, add `vaadin-dev` dependency as a `optional` scope in project `<dependencies>`. Spring Boot 4 `spring-boot-maven-plugin` automatically excludes optional dependencies from the final build: | ||
|
|
||
| .`pom.xml` | ||
| [source,xml] | ||
| ---- | ||
| <dependencies> | ||
| ... | ||
| <dependency> | ||
| <groupId>com.vaadin</groupId> | ||
| <artifactId>vaadin-dev</artifactId> | ||
| <optional>true</optional> | ||
| </dependency> | ||
| ... | ||
| </dependencies> | ||
| ---- | ||
|
|
||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd move this snippet to up (before a snippet with profile) so as to make it a primary recommended way for spring apps.
| mvn clean package | ||
| ---- | ||
|
|
||
| For other applications, e.g., Jakarta EE or plain Java, and for better backwards compatibility, run same with a production profile: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be easier to read if this can give a link to the fragment where the production profile is defined.
Removed production profile from articles that use example apps that build or will build production package without any production profile.
Part of vaadin/flow#22464
WIP: starters are not updated yet and they are pending on new Spring Boot 4 release that enables removal of the production profile.