Skip to content

Conversation

@tepi
Copy link
Contributor

@tepi tepi commented Sep 16, 2025

Related-to #4574

@tepi tepi marked this pull request as draft September 16, 2025 06:20
@mshabarov
Copy link
Contributor

mshabarov commented Oct 17, 2025

@rolfsmeds @yuriy-fix

we added "Changes In Theming System" sub-chapter to this PR with some overview, but feel free to change the title and supplement the content, also please add the content for Web Components/Flow Components. I suggest to create a new branch on top of this branch and put your content there, this way it will be automatically synchronized with this branch and main.

@mshabarov mshabarov marked this pull request as ready for review October 17, 2025 12:53
@mshabarov mshabarov requested a review from caalador October 20, 2025 11:36
@mshabarov
Copy link
Contributor

Needs to be rebased to main branch.

@mshabarov mshabarov force-pushed the feat/vaadin-24-to-25-upgrade-guide branch from 6d1f5e1 to 89d4d46 Compare October 20, 2025 12:59
@CLAassistant
Copy link

CLAassistant commented Oct 20, 2025

CLA assistant check
All committers have signed the CLA.

@mshabarov mshabarov changed the base branch from next to main October 20, 2025 12:59
@mshabarov mshabarov force-pushed the feat/vaadin-24-to-25-upgrade-guide branch from 89d4d46 to cc86e8f Compare October 20, 2025 13:02
@github-actions
Copy link

github-actions bot commented Oct 20, 2025

AI Language Review

The new file is complete and quite comprehensive. It covers a wide range of aspects related to upgrading from Vaadin 23 and 24 to newer versions. The information presented appears accurate and well-organized, aligning well with the guidelines for technical documentation.

Overall, the file looks solid, with no apparent areas requiring improvement or adjustment at this point. However, a real-world review would typically involve checking current compatibility and accuracy with live systems and environments, which can't be fully assessed in this static context.

tepi and others added 3 commits October 21, 2025 12:52
Co-authored-by: caalador <mikael.grankvist@vaadin.com>
Co-authored-by: caalador <mikael.grankvist@vaadin.com>
Co-authored-by: caalador <mikael.grankvist@vaadin.com>
@vaadin vaadin deleted a comment from Rolf Oct 21, 2025
@mshabarov mshabarov requested a review from caalador October 22, 2025 12:15
@mshabarov
Copy link
Contributor

@tepi @tltv please sign the CLA.

@mshabarov mshabarov merged commit a83f74a into main Oct 23, 2025
4 checks passed
@mshabarov mshabarov deleted the feat/vaadin-24-to-25-upgrade-guide branch October 23, 2025 11:26
@mshabarov
Copy link
Contributor

Fixes #4687

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants