Skip to content

Add requirements for using Flyway #4367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 16, 2025

Conversation

MatthewVaadin
Copy link
Contributor

This adds the instructions for how to use Flyway in an application with Control Center.

Part of https://github.com/vaadin/control-center/issues/946

Copy link

github-actions bot commented Jun 5, 2025

AI Language Review

The changes between the flyway-migrations files include adding a requirement for the Flyway PostgreSQL dependency in the updated .pom.xml section. This addition is necessary and accurate given that utilizing Flyway with PostgreSQL would require this specific dependency.

One point of suggestion for improvement:

  • In the flyway-migrations file, consider explicitly mentioning that the Control Center Starter dependency already brings in Flyway support, which may help prevent confusion about whether both dependencies are always needed together. It would clarify that the PostgreSQL-specific Flyway dependency is only necessary for databases managed with PostgreSQL.

For the database file:

  • The repeated use of "setup" when it should be "set up" as a verb form: "how to setup Flyway" should be corrected to "how to set up Flyway".

These adjustments would improve clarity and accuracy in the context of dependency management and usage guidance.

@MatthewVaadin MatthewVaadin self-assigned this Jun 5, 2025
@peholmst
Copy link
Member

Just mentioning this guide as well: https://vaadin.com/docs/latest/building-apps/forms-data/add-flyway
There could at least be links between it and the Control Center guides.

@MatthewVaadin MatthewVaadin merged commit e20ef82 into latest Jun 16, 2025
4 of 5 checks passed
@MatthewVaadin MatthewVaadin deleted the control-center/946/add-flyway-procedure branch June 16, 2025 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants